[NV] Speedbench-al: fix --chat-template-kwargs default quoting so thinking-on cells run#1685
Closed
qiching wants to merge 1 commit into
Closed
Conversation
qiching
changed the title
xinli-sw
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collector set
CHAT_TEMPLATE_KWARGS_ON="${VAR:-{...}}", but bash ends the parameter expansion at the first }, so the trailing } is appended as a literal. It worked locally because the var was unset (default path lands on a single brace), in CI the workflow passes the var in, so the value became {...}} invalid JSON. Fixed by moving the default into its own variable so there are no brace-literals in the expansion.Parent PR: #1650
Note
Low Risk
Single-line bash env default change in a benchmark collector script; no production serving or auth paths affected.
Overview
Fixes thinking-on SPEED-Bench AL collection in CI by correcting how the default
CHAT_TEMPLATE_KWARGS_ONJSON is assigned indsv4_fp4_b300_vllm.sh.The previous inline default inside
${CHAT_TEMPLATE_KWARGS_ON:-{...}}was parsed incorrectly by bash (expansion stops at the first}), which could yield malformed JSON when the workflow exports the variable. The default is now stored inDEFAULT_CHAT_TEMPLATE_KWARGS_ONand referenced via${CHAT_TEMPLATE_KWARGS_ON:-$DEFAULT_CHAT_TEMPLATE_KWARGS_ON}, so--chat-template-kwargsgets valid{"thinking": true, "reasoning_effort": "high"}for thinking-on cells.Reviewed by Cursor Bugbot for commit e101f36. Bugbot is set up for automated code reviews on this repo. Configure here.